Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24022
to look at the new patch set (#4).
Change subject: IMPALA-14691: Only log modified query options
......................................................................
IMPALA-14691: Only log modified query options
Instead of always logging every query option as a key value pair,
only log the ones differing from their default values as defined
in TQueryOptions.
Most of the time, most, if not all, query options are not overridden,
and use the default value. Logging only the modified values gives a
shorter and more understandable information, as the full list is very
long.
A function to extract the necessary list of modified values already
exists (DebugQueryOptions), and is used e.g. in query profile.
An example to the per query log, with one option changed:
TClientRequest.queryOptions: ABORT_ON_ERROR=1
The list of changed query options will be listed independently of
where the set happens. For example, both values set with
--default_query_options startup param, and values changed with SET
inside impala shell will be listed if different from default value
in TQueryOptions.
Change-Id: Ibcd9eb80afaa3171f5436cabb4703bbae4581396
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/24022/4
--
To view, visit http://gerrit.cloudera.org:8080/24022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibcd9eb80afaa3171f5436cabb4703bbae4581396
Gerrit-Change-Number: 24022
Gerrit-PatchSet: 4
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
