Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 )
Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10654/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10654/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@593 PS4, Line 593: return Sets.newHashSet(partitionMap_.keySet()); Now that we don't need to modify the key set, could we just use Collections.unmodifiableSet() here, and then keep the call-sites as-is using addAll where they might try to modify it? Then we can leave the interface type as Set<> and this patch will only be a few lines? -- To view, visit http://gerrit.cloudera.org:8080/10654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5a480e570aeae565fafd4f3e2b279e7a98c7da Gerrit-Change-Number: 10654 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 17:52:21 +0000 Gerrit-HasComments: Yes
