Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 )
Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py@177 PS15, Line 177: pytest.skip() > I preferred to disable this test for two reasons: The problem with skipping though is that no one will remember to un-skip this test again once HIVE-19830 is fixed, since it does not show up anywhere. If an assert fails causing a test failure, someone will revisit this and fix the assert/behavior of the test. http://gerrit.cloudera.org:8080/#/c/10543/17/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10543/17/tests/metadata/test_partition_metadata.py@168 PS17, Line 168: false False. This was caught by impala-flake8. Can you run it on this file and fix the errors? (not everything is related to this patch though) $ impala-flake8 tests/metadata/test_partition_metadata.py tests/metadata/test_partition_metadata.py:22:5: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:23:1: F401 'tests.util.filesystem_utils.get_fs_path' imported but unused tests/metadata/test_partition_metadata.py:29:19: E201 whitespace after '{' tests/metadata/test_partition_metadata.py:30:5: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:30:26: E202 whitespace before '}' tests/metadata/test_partition_metadata.py:35:1: E302 expected 2 blank lines, found 1 tests/metadata/test_partition_metadata.py:49:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:55:27: E261 at least two spaces before inline comment tests/metadata/test_partition_metadata.py:73:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:75:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:128:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:130:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:132:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:149:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:149:39: E703 statement ends with a semicolon tests/metadata/test_partition_metadata.py:168:12: F821 undefined name 'false' tests/metadata/test_partition_metadata.py:194:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:196:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:224:76: E502 the backslash is redundant between brackets tests/metadata/test_partition_metadata.py:225:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:226:75: E502 the backslash is redundant between brackets tests/metadata/test_partition_metadata.py:227:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:238:74: E502 the backslash is redundant between brackets tests/metadata/test_partition_metadata.py:239:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:271:5: F841 local variable 'file_format' is assigned to but never used tests/metadata/test_partition_metadata.py:277:9: E122 continuation line missing indentation or outdented tests/metadata/test_partition_metadata.py:287:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:290:9: E122 continuation line missing indentation or outdented tests/metadata/test_partition_metadata.py:301:9: E122 continuation line missing indentation or outdented tests/metadata/test_partition_metadata.py:307:9: E128 continuation line under-indented for visual indent tests/metadata/test_partition_metadata.py:315:9: E122 continuation line missing indentation or outdented -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 17 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 21:19:28 +0000 Gerrit-HasComments: Yes
