Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10778 )
Change subject: IMPALA-7191: don't call srand() at random times ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10778/1/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10778/1/be/src/common/init.cc@176 PS1, Line 176: srand(time(NULL)); > Would it be better to use random_device here? I don't think it matters. If we require more randomness than this then we probably shouldn't be using rand() in those places to begin with. -- To view, visit http://gerrit.cloudera.org:8080/10778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0ef5a0e842ebdcdb6d7355302e68fb0bc7ef5f Gerrit-Change-Number: 10778 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 22:48:11 +0000 Gerrit-HasComments: Yes
