Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10778 )
Change subject: IMPALA-7191: don't call srand() at random times ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10778/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/10778/2/be/src/runtime/krpc-data-stream-sender.cc@a604 PS2, Line 604: > Not sure if it warrants a comment that the random number generator is seede I don't think so but I can add it if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/10778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0ef5a0e842ebdcdb6d7355302e68fb0bc7ef5f Gerrit-Change-Number: 10778 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 22:57:04 +0000 Gerrit-HasComments: Yes
