Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24055 )
Change subject: IMPALA-14763: Prevent admissiond OOM during request decompression ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24055/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24055/2//COMMIT_MSG@21 PS2, Line 21: new memory : tracker > New memtracker makes sense. Note, that even with this the Scheduler might a Yes, other places could still potentially hit OOM if large allocations happen without proper protection. That will be tracked in IMPALA-14499 http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc@361 PS2, Line 361: // Only works when in a admissiond process. > typo: adminssiond -> admissiond Done http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc@1766 PS2, Line 1766: ery_id=" << PrintId(request.que > why do we only check the limit for uncompressed requests? The check for uncompressed path and the compressed path are different. This place only checks for uncompressed, where memory usage does not change because no decompression is required. Therefore, the uncompressed path only needs to be checked once. The compressed goes in another path, in the GetQueryExecRequest() to the check is performed each time when decompression is needed, for submission it is in L1695. -- To view, visit http://gerrit.cloudera.org:8080/24055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I196455f445f0644d89467a23b4ec1f64f184f2db Gerrit-Change-Number: 24055 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 03:27:17 +0000 Gerrit-HasComments: Yes
