Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24055 )
Change subject: IMPALA-14763: Prevent admissiond OOM during request decompression ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/24055/2/be/src/scheduling/admission-controller.cc@1766 PS2, Line 1766: ery_id=" << PrintId(request.que > On second thought, maybe it is good to have a consistent check here. It doe I think either approach is fine, I was hoping a comment explaining the exclusion of compressed requests in the previous patch. http://gerrit.cloudera.org:8080/#/c/24055/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/24055/4/tests/custom_cluster/test_admission_controller.py@2599 PS4, Line 2599: def test_admission_service_safeguard_large_compressed_query(self): This should fail for both compressed and uncompressed requests, no? So maybe update the test-case name and comment assuming this test runs with both compressed/un-compressed exec requests? -- To view, visit http://gerrit.cloudera.org:8080/24055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I196455f445f0644d89467a23b4ec1f64f184f2db Gerrit-Change-Number: 24055 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 22:55:00 +0000 Gerrit-HasComments: Yes
