Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24064 )
Change subject: IMPALA-14803: Speed up Iceberg table minimal topic updates ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1951 PS2, Line 1951: addHdfsPartitionsToCatalogDelta((HdfsTable) tbl, ctx); > I think the table type from here is not used. The returned object is used i I did something like your original suggestion and used toInvalidationObject() indirectly through toTCatalogObject() Note that I removed the TCatalogObjectType.VIEW related code below as the type is properly set in toTCatalogObject() and the HdfsTable path can't have views/incomplete tables. -- To view, visit http://gerrit.cloudera.org:8080/24064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If037a855dc5d2c4292347b34ebe0221477eae2fe Gerrit-Change-Number: 24064 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 15:37:39 +0000 Gerrit-HasComments: Yes
