Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24064 )
Change subject: IMPALA-14803: Speed up Iceberg table minimal topic updates ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1951 PS2, Line 1951: addHdfsPartitionsToCatalogDelta((HdfsTable) tbl, ctx); > I did something like your original suggestion and used toInvalidationObject Ack http://gerrit.cloudera.org:8080/#/c/24064/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/24064/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1953 PS6, Line 1953: catalogTbl = tbl.toTCatalogObject(CatalogObject.ThriftObjectType.INVALIDATION); : } else { : catalogTbl = tbl.toTCatalogObject(CatalogObject.ThriftObjectType.FULL); nit: using toInvalidationObject() and toTCatalogObject() directly saves a swich check. Though the difference is negligible, it also simplies the code. -- To view, visit http://gerrit.cloudera.org:8080/24064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If037a855dc5d2c4292347b34ebe0221477eae2fe Gerrit-Change-Number: 24064 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2026 05:47:26 +0000 Gerrit-HasComments: Yes
