Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24063 )
Change subject: IMPALA-14794: Implement small string optimization in Parquet scanner ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/24063/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24063/7//COMMIT_MSG@26 PS7, Line 26: Before: : KrpcDataStreamSender: SerializeBatchTime: 84.385ms : HDFS_SCAN_NODE: MaterializeTupleTime: 8.183ms : After: > Can you include other metrics, e.g. scan times (e.g. MaterializeTupleTime)? Done http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-chunk-reader.h File be/src/exec/parquet/parquet-column-chunk-reader.h: http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-chunk-reader.h@176 PS7, Line 176: by the last row b > nit: by the last row batch. Done http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-chunk-reader.cc@173 PS7, Line 173: the last row b > nit: the last row batch. Done http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-readers.cc@837 PS7, Line 837: DCHECK(!val.CanBeSmallified()); > We could add DCHECK_FALSE(val.Smallify()); Done http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-readers.cc@870 PS7, Line 870: if (!val->IsSmall()) { > We could add DCHECK_FALSE(val.Smallify()); Done http://gerrit.cloudera.org:8080/#/c/24063/7/be/src/exec/parquet/parquet-column-readers.cc@963 PS7, Line 963: for (int i = 0; i < count; ++i) { > We could add DCHECK_FALSE(val.Smallify()); Done -- To view, visit http://gerrit.cloudera.org:8080/24063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16c550d35cd6d3ec259b899b325611294137ccef Gerrit-Change-Number: 24063 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:18:20 +0000 Gerrit-HasComments: Yes
