Balazs Hevele has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24063 )

Change subject: IMPALA-14794: Implement small string optimization in Parquet 
scanner
......................................................................


Patch Set 9:

There was a crash found in https://jenkins.impala.io/job/perf-AB-test-ub2004/390
dict_page_pool_ can be nullptr when there are no var len values. In this case, 
there is no need to call FreeAll/AcquireData in CreateDictionaryDecoder, so 
added a nullptr check around it.


--
To view, visit http://gerrit.cloudera.org:8080/24063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c550d35cd6d3ec259b899b325611294137ccef
Gerrit-Change-Number: 24063
Gerrit-PatchSet: 9
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 11 Mar 2026 13:22:35 +0000
Gerrit-HasComments: No

Reply via email to