Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24110 )
Change subject: IMPALA-14807: Fix squeasel MD5 issue in OpenSSL 3.0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24110/1/be/src/thirdparty/squeasel/squeasel.c File be/src/thirdparty/squeasel/squeasel.c: http://gerrit.cloudera.org:8080/#/c/24110/1/be/src/thirdparty/squeasel/squeasel.c@1566 PS1, Line 1566: EVP_DigestUpdate(ctx, (const unsigned char *) p, strlen(p)); > Should we confirm hash_len is 16? EVP_MAX_MD_SIZE looks like it can go to 3 Yeah, https://docs.openssl.org/3.5/man3/EVP_md5/#synopsis I think the EVP_md5() will always output 16 bytes (128 bits). Added an exception handling here. http://gerrit.cloudera.org:8080/#/c/24110/1/be/src/thirdparty/squeasel/squeasel.c@3102 PS1, Line 3102: } > I'm surprised sizeof(sha) works here. I guess it doesn't care that it's dec Good catch. Maybe it will fall into a undefined case. I added a const for sha output instead. -- To view, visit http://gerrit.cloudera.org:8080/24110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I806394633eaa73d973c27988fd303004487ddb4a Gerrit-Change-Number: 24110 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 23:11:59 +0000 Gerrit-HasComments: Yes
