Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24110 )
Change subject: IMPALA-14807: Fix squeasel MD5 issue in OpenSSL 3.0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24110/2/be/src/thirdparty/squeasel/squeasel.c File be/src/thirdparty/squeasel/squeasel.c: http://gerrit.cloudera.org:8080/#/c/24110/2/be/src/thirdparty/squeasel/squeasel.c@1572 PS2, Line 1572: } > I think an assert would be fine here if it's really a promise from the API. Added some checks for EVP_Digest* functions could potentially fail and return 0, and added the assert after that. -- To view, visit http://gerrit.cloudera.org:8080/24110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I806394633eaa73d973c27988fd303004487ddb4a Gerrit-Change-Number: 24110 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2026 17:57:44 +0000 Gerrit-HasComments: Yes
