Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24118 )
Change subject: IMPALA-14843: Show cancelled nodes in ExecSummary ...................................................................... Patch Set 1: (1 comment) Thanks! Looks good to me, I just have one nit/question. http://gerrit.cloudera.org:8080/#/c/24118/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/24118/1/be/src/runtime/coordinator.cc@1802 PS1, Line 1802: -1 nit: instead of a magic number, we could define a constant somewhere? Or mention it in the comment that sinks always have -1 as id? (we have a SINK_ID at https://gerrit.cloudera.org/c/24118/1/be/src/service/impala-http-handler.cc#1087 but that's in an unnamed namespace) -- To view, visit http://gerrit.cloudera.org:8080/24118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1bf51112e7c8c5609bb9e9525d960efc524215 Gerrit-Change-Number: 24118 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2026 10:23:41 +0000 Gerrit-HasComments: Yes
