Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24118 )
Change subject: IMPALA-14843: Show cancelled nodes in ExecSummary ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24118/3/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/24118/3/be/src/runtime/fragment-instance-state.cc@365 PS3, Line 365: if (node->name().rfind(hash_type, 0) == 0 > I'm generally not in favor of relying on the profile having certain entries That's a cleaner solution! Updated the patch for this part. Added a map from plan node id to the ExecNode* so we can find the node here. -- To view, visit http://gerrit.cloudera.org:8080/24118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1bf51112e7c8c5609bb9e9525d960efc524215 Gerrit-Change-Number: 24118 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2026 03:04:08 +0000 Gerrit-HasComments: Yes
