Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 )
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/CMakeLists.txt File be/src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/CMakeLists.txt@213 PS1, Line 213: if(NOT NO_NVM_SUPPORT) Can this be applied to Kudu code base so we don't have to reapply this patch every time ? Same below. http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/cache.cc File be/src/kudu/util/cache.cc: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/cache.cc@563 PS1, Line 563: !defined(NO_NVM_SUPPORT) Please see comments in CMakeList.txt. http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/locks.h File be/src/kudu/util/locks.h: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/locks.h@183 PS1, Line 183: !defined(HAVE_SCHED_GETCPU) Can HAVE_SCHED_GETCPU be added to Kudu code base and remove defined(__APPLE__) branch of the #if statement ? http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/net/socket.cc File be/src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/net/socket.cc@131 PS1, Line 131: && defined(SOCK_NONBLOCK) && defined(SOCK_CLOEXEC) This also seems applicable to Kudu too and makes the build more robust across different platforms. http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/subprocess.cc File be/src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/subprocess.cc@298 PS1, Line 298: !defined(HAVE_PIPE2) Also applicable to Kudu code base. May be we can replace (__APPLE__) with (HAVE_PIPE2). -- To view, visit http://gerrit.cloudera.org:8080/10758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I451f02d3e4669e8a548b92fb1445cb2b322659a2 Gerrit-Change-Number: 10758 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 22:57:57 +0000 Gerrit-HasComments: Yes
