Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 )
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/CMakeLists.txt File be/src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10758/1/be/src/kudu/util/CMakeLists.txt@213 PS1, Line 213: if(NOT NO_NVM_SUPPORT) > Can this be applied to Kudu code base so we don't have to reapply this patc After this change we should probably start continuously cherry-picking changes from Kudu instead of waiting for things to get bad again. This flag was added only for us and is manually set in the top-level CMakeLists.txt to remove support for libvmem (together with NO_TESTS). Do you think Kudu would have a use for having such a flag themselves? -- To view, visit http://gerrit.cloudera.org:8080/10758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I451f02d3e4669e8a548b92fb1445cb2b322659a2 Gerrit-Change-Number: 10758 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 00:48:36 +0000 Gerrit-HasComments: Yes
