Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments ...................................................................... Patch Set 1: (1 comment) As you mentioned, if people rely on using variable substitution for query hints, it will break them. http://gerrit.cloudera.org:8080/#/c/10784/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10784/1/tests/shell/test_shell_interactive.py@466 PS1, Line 466: run_impala_shell_interactive('drop table if exists var_comments;') I don't think it works for this case. impala-shell.sh --var=foo=functional.alltypes [localhost:21000] default> /* ${var:foo} */ select * from ${var:foo} limit 5; Query: /* functional.alltypes */ select * from functional.alltypes limit 5 -- To view, visit http://gerrit.cloudera.org:8080/10784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c Gerrit-Change-Number: 10784 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 02:56:01 +0000 Gerrit-HasComments: Yes
