Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10784/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10784/2/tests/shell/test_shell_interactive.py@484 PS2, Line 484: result = run_impala_shell_interactive('/* ${var:foo} */\n' It fails for this case, too impala-shell.sh --var=foo=functional.alltypes --var=bar=hello /*${var:foo} ${var:bar} */ select * from ${var:foo} limit 1; Query: /*functional.alltypes ${var:bar} */ select * from functional.alltypes limit 1 -- To view, visit http://gerrit.cloudera.org:8080/10784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c Gerrit-Change-Number: 10784 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 19:05:41 +0000 Gerrit-HasComments: Yes
