Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 )
Change subject: Add scripts to create code coverage reports ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Looks fine to me. I'd love to see some demo output at some point. http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh File bin/coverage_helper.sh: http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@1 PS1, Line 1: #!/bin/bash I'm increasingly of the opinion that we should just start with python for this kind of thing. You'll save on lines 26-52 by using more obvious argparse, for example. http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@24 PS1, Line 24: REPORT_DIRECTORY=${IMPALA_HOME}/logs/coverage Does something mkdir -p this? http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@30 PS1, Line 30: echo "[-reportdirectory] : Output directory for coverage report files" Indicate that this takes an argument? -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 16:48:04 +0000 Gerrit-HasComments: Yes
