Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 )
Change subject: Add scripts to create code coverage reports ...................................................................... Patch Set 1: (3 comments) Made this into a JIRA IMPALA-7199. There is example output in a tarball there. http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh File bin/coverage_helper.sh: http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@1 PS1, Line 1: #!/bin/bash > I'm increasingly of the opinion that we should just start with python for t I'll take a look at how that would be. http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@24 PS1, Line 24: REPORT_DIRECTORY=${IMPALA_HOME}/logs/coverage > Does something mkdir -p this? I do this down in the REPORT_ACTION = 1 block. http://gerrit.cloudera.org:8080/#/c/10791/1/bin/coverage_helper.sh@30 PS1, Line 30: echo "[-reportdirectory] : Output directory for coverage report files" > Indicate that this takes an argument? Done -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 22:47:48 +0000 Gerrit-HasComments: Yes
