Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24248 )
Change subject: IMPALA-14847: Add diagnostics for large ExecQueryFInstances RPCs ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24248/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24248/1//COMMIT_MSG@23 PS1, Line 23: TQueryCtx > It'd be helpful to print the size of TDescriptorTableSerialized in TQueryCt Good point, threaded that through and added it. http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.h@456 PS1, Line 456: * > nit: to be consistent with other code's style, use "int64_t* total_scan_ran Done http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc@124 PS1, Line 124: int64_t * > nit: same here Done http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc@153 PS1, Line 153: fragment_info->fragments.push_back(*fragment); > This could also be large for queries that have lots of constant strings, e. I ran an insert with a big VALUES clause and included that in the commit message. The output includes the TQueryCtx, which would be the major piece of TExecRequest. http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc@349 PS1, Line 349: CopyFilepathToHostsMappingToRequest(&request); > by_node_filepath_to_hosts set in this could also be large if there are lots Created an addendum patch to add this -- To view, visit http://gerrit.cloudera.org:8080/24248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e1fd50bf2fec2b8969585f7fcec2ca2487e181 Gerrit-Change-Number: 24248 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2026 18:59:21 +0000 Gerrit-HasComments: Yes
