Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24248 )
Change subject: IMPALA-14847: Add diagnostics for large ExecQueryFInstances RPCs ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24248/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24248/2//COMMIT_MSG@15 PS2, Line 15: 1. It prints a warning about ExecQueryFInstances RPCs that > Maybe have different treshold for warning and error? Maybe it's OK for warnings/errors. We already have cancellation logs per backend, e.g. https://github.com/apache/impala/blob/042b915c9ec7feb0398bdec84027e908ada59725/be/src/runtime/coordinator-backend-state.cc#L665 https://github.com/apache/impala/blob/042b915c9ec7feb0398bdec84027e908ada59725/be/src/runtime/coordinator-backend-state.cc#L688 http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/24248/1/be/src/runtime/coordinator-backend-state.cc@153 PS1, Line 153: fragment_info->fragments.push_back(*fragment); > I ran an insert with a big VALUES clause and included that in the commit me Ack. I think TQueryCtx is large in this case since the statement itself is long so TQueryCtx.client_request.stmt is large. That's OK to identify this case. -- To view, visit http://gerrit.cloudera.org:8080/24248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e1fd50bf2fec2b8969585f7fcec2ca2487e181 Gerrit-Change-Number: 24248 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 11:18:04 +0000 Gerrit-HasComments: Yes
