Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24205 )
Change subject: IMPALA-14884: Implement SHOW CURRENT GROUPS statement ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24205/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24205/7//COMMIT_MSG@15 PS7, Line 15: This also slightly extends how 'struct_field_def' can grow via 'word' so : that we could still support the following statement afterward. : : CREATE TABLE t (i STRUCT<groups:INT>); > don't know how expensive is to get the group list - doing this for each query > like user name may be too expensive SHOW CURRENT GROUPS implemented in this patch should not be too expensive. Under the covers we call "RangerUtil#getUGroups(String userShortName)" at https://gerrit.cloudera.org/c/24205/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerUtil.java#100. Before this patch, for a statement that needed to be authorized, we already made a call to getUserGroups(user) as shown at https://github.com/apache/impala/blob/042b915/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java#L700. I don't know the exact cost of making this call to getUserGroups(user), but SHOW CURRENT GROUPS should not be more expensive than any statement that needs to be authorized. -- To view, visit http://gerrit.cloudera.org:8080/24205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d65c6d038e9bb2d56c6c2510eaf52a8c27965c8 Gerrit-Change-Number: 24205 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 18:05:32 +0000 Gerrit-HasComments: Yes
