Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24205 )

Change subject: IMPALA-14884: Implement SHOW CURRENT GROUPS statement
......................................................................


Patch Set 9:

(1 comment)

I have addressed Michael's comment on the previous patch. Let me know if there 
are additional suggestions. Thanks!

http://gerrit.cloudera.org:8080/#/c/24205/8/be/src/service/frontend.h
File be/src/service/frontend.h:

http://gerrit.cloudera.org:8080/#/c/24205/8/be/src/service/frontend.h@151
PS8, Line 151:   /// Call FE to get the groups associated with the effective 
user.
> Functions tend to have a function comment here.
Thanks for pointing this out! I will add a code comment for this function in 
the next patch.



--
To view, visit http://gerrit.cloudera.org:8080/24205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d65c6d038e9bb2d56c6c2510eaf52a8c27965c8
Gerrit-Change-Number: 24205
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Fri, 08 May 2026 04:06:46 +0000
Gerrit-HasComments: Yes

Reply via email to