Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24275 )
Change subject: IMPALA-14949: Fix Catalogd Startup Deadlock ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24275/3/tests/custom_cluster/test_catalog_wait.py File tests/custom_cluster/test_catalog_wait.py: http://gerrit.cloudera.org:8080/#/c/24275/3/tests/custom_cluster/test_catalog_wait.py@142 PS3, Line 142: lock = threading.Lock() > The lock isn't needed; Python GIL ensures basic assignment is atomic. But i Yeah, I think we don't need the lock. We have other examples like https://github.com/apache/impala/blob/f7b4601482ab698ff524a68e89c9485299879062/tests/custom_cluster/test_local_catalog.py#L441-L462 https://github.com/apache/impala/blob/f7b4601482ab698ff524a68e89c9485299879062/tests/custom_cluster/test_concurrent_ddls.py#L181-L198 http://gerrit.cloudera.org:8080/#/c/24275/3/tests/custom_cluster/test_catalog_wait.py@179 PS3, Line 179: sleep(5) > Could this be a check for inflight queries from a metric or the /queries pa I think we can let the thread add a marker and wait for the marker to appear. http://gerrit.cloudera.org:8080/#/c/24275/3/tests/custom_cluster/test_catalog_wait.py@218 PS3, Line 218: sleep(1) By not killing the impalads, I found the queries all finish at the end. The longest duration is 34s. If I increase the sleep interval to 5s, the test passes without the fix. http://gerrit.cloudera.org:8080/#/c/24275/3/tests/custom_cluster/test_catalog_wait.py@226 PS3, Line 226: impalad.kill() Why should we explicitly kill the impalads? -- To view, visit http://gerrit.cloudera.org:8080/24275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe71980d6fed5a95b00bc7b710c781f909545404 Gerrit-Change-Number: 24275 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 13:18:35 +0000 Gerrit-HasComments: Yes
