Jason Fehr has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/24275 )
Change subject: [WIP] IMPALA-14949: Fix Catalogd Startup Deadlock ...................................................................... [WIP] IMPALA-14949: Fix Catalogd Startup Deadlock The getOrLoadTable functionality now waits for the initial database metadata to be loaded for the given database before it takes the versionLock_ read lock. This order of operations is reversed from its previous ordering. There was a deadlock condition during a slow Catalogd startup because the thread that performs the initial global reset periodically releases the versionLock_ write lock to allow for metadata operations on already loaded databases to proceed. If the database was not yet loaded, the read thread waited until it was loaded holding a read lock on versionLock_. However, the initial global reset thread could not proceed with loading any databases because it needed a write lock on versionLock_. Testing accomplished with a new custom cluster test. This new test was run on a local Impala dev machine without the fix in place to demonstrate it consistently failed because of the deadlock. It was also successfully run with the fix in place both on a local Impala dev machine and in an automated build. Change-Id: Ibe71980d6fed5a95b00bc7b710c781f909545404 --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M tests/custom_cluster/test_catalog_wait.py 2 files changed, 137 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/24275/6 -- To view, visit http://gerrit.cloudera.org:8080/24275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe71980d6fed5a95b00bc7b710c781f909545404 Gerrit-Change-Number: 24275 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
