Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc@304 PS4, Line 304: DCHECK_NE(builder_, nullptr); > How do you know builder_ is not null here? Because waited_for_build_ is alw Yes, that's right. waited_for_build_ can only be set to true after builder_ is set. The code that looks up the builder when it is null DCHECKs that waited_for_build_ is false, so we can't have been using that path before. -- To view, visit http://gerrit.cloudera.org:8080/24279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d Gerrit-Change-Number: 24279 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 17:41:13 +0000 Gerrit-HasComments: Yes
