Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h File be/src/exec/blocking-join-node.h: http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h@272 PS4, Line 272: RuntimeState* state, T** builder Minor thing, adding a couple of DCHECKs seem safer as a separate function. DCHECK(state != nullptr); DCHECK(builder != nullptr); -- To view, visit http://gerrit.cloudera.org:8080/24279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d Gerrit-Change-Number: 24279 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2026 21:57:02 +0000 Gerrit-HasComments: Yes
