Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24248 )
Change subject: IMPALA-14847: Add diagnostics for large ExecQueryFInstances RPCs ...................................................................... Patch Set 5: (3 comments) I'm doing one last rework, sorry for the disruption. The priority_queue is complicated and I'm replacing it with a std::multimap to simplify the code. http://gerrit.cloudera.org:8080/#/c/24248/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24248/5//COMMIT_MSG@42 PS5, Line 42: TQueryCTX > nit: "TQueryCtx" Done http://gerrit.cloudera.org:8080/#/c/24248/5/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/24248/5/be/src/runtime/coordinator-backend-state.cc@382 PS5, Line 382: > nit: should use single space here Done http://gerrit.cloudera.org:8080/#/c/24248/5/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/24248/5/be/src/runtime/coordinator.cc@1929 PS5, Line 1929: std::move > nit: We are actually copying the string since it's returned by a const refe The priority_queue has added a bunch of complication and subtlety around how things are ordered. I'm swapping it out for a std::multimap, so then we don't need any of this stack code. I also changed ReportRpcSizeWithWarning to take an rvalue reference to avoid that copy. -- To view, visit http://gerrit.cloudera.org:8080/24248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e1fd50bf2fec2b8969585f7fcec2ca2487e181 Gerrit-Change-Number: 24248 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 21:31:18 +0000 Gerrit-HasComments: Yes
