Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24248 )
Change subject: IMPALA-14847: Add diagnostics for large ExecQueryFInstances RPCs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24248/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/24248/4/be/src/runtime/coordinator.cc@1929 PS4, Line 1929: warnings.push(largest_rpc_warnings_.top().second); > Let's make this an emplace(move(...)) to avoid copies. Done -- To view, visit http://gerrit.cloudera.org:8080/24248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e1fd50bf2fec2b8969585f7fcec2ca2487e181 Gerrit-Change-Number: 24248 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 21:13:37 +0000 Gerrit-HasComments: Yes
