Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24205 )

Change subject: IMPALA-14884: Implement SHOW CURRENT GROUPS statement
......................................................................


Patch Set 10:

(1 comment)

I have addressed Csaba's comment on patch set 9. Let me know if there are 
additional suggestions. Thanks!

http://gerrit.cloudera.org:8080/#/c/24205/9/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/24205/9/tests/authorization/test_ranger.py@2337
PS9, Line 2337:   @CustomClusterTestSuite.with_
> nit: I don't see why execute_serially is needed besides being in a CustomCl
Thanks for pointing this out Csaba!

You are correct. Most tests in test_ranger.py have to be executed serially 
because a lot of the tests are changing Ranger's policy repository. But since 
the user-to-groups mapping is always static as dictated by the startup flag of 
'--use_customized_user_groups_mapper_for_ranger', I will remove this decorator 
in the next patch.



--
To view, visit http://gerrit.cloudera.org:8080/24205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d65c6d038e9bb2d56c6c2510eaf52a8c27965c8
Gerrit-Change-Number: 24205
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 11 May 2026 18:03:17 +0000
Gerrit-HasComments: Yes

Reply via email to