Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 2: (20 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.h File be/src/service/query-profile-ai-analysis.h: http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.h@30 PS2, Line 30: const std::string& tool_name, const std::string& tool_args_json, std::string* tool_json)>; line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@93 PS2, Line 93: {"type":"function","function":{"name":"get_summary","description":"Get the Summary section of the Impala query profile, including query metadata and top-level fields.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (233 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@94 PS2, Line 94: {"type":"function","function":{"name":"get_timeline","description":"Get the Query Timeline section.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (166 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@95 PS2, Line 95: {"type":"function","function":{"name":"get_compilation","description":"Get the Query Compilation section.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (172 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@96 PS2, Line 96: {"type":"function","function":{"name":"get_execution_profile","description":"Get the Execution Profile section.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (178 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@97 PS2, Line 97: {"type":"function","function":{"name":"get_fragments_overview","description":"Get a condensed overview of all fragments to triage bottlenecks.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (209 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@98 PS2, Line 98: {"type":"function","function":{"name":"get_fragment","description":"Get a specific fragment by fragment_id (e.g. F00, F01, 00, 01).","parameters":{"type":"object","properties":{"fragment_id":{"type":"string","description":"Fragment ID to retrieve"}},"required":["fragment_id"]}}}, line too long (282 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@99 PS2, Line 99: {"type":"function","function":{"name":"get_fragment_instances","description":"Get all instances for a specific fragment.","parameters":{"type":"object","properties":{"fragment_id":{"type":"string","description":"Fragment ID to retrieve instances for"}},"required":["fragment_id"]}}}, line too long (285 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@100 PS2, Line 100: {"type":"function","function":{"name":"get_node","description":"Get a specific execution node by node_id, optionally scoped to fragment_id.","parameters":{"type":"object","properties":{"node_id":{"type":"string","description":"Node ID to retrieve"},"fragment_id":{"type":"string","description":"Optional fragment ID to scope search"}},"required":["node_id"]}}}, line too long (363 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@101 PS2, Line 101: {"type":"function","function":{"name":"get_scan_nodes_summary","description":"Get a condensed summary of SCAN nodes.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (183 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@102 PS2, Line 102: {"type":"function","function":{"name":"get_per_node_profiles","description":"Get the Per Node Profiles section.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (178 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@103 PS2, Line 103: {"type":"function","function":{"name":"get_query_options","description":"Get query options used by the query.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (176 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@104 PS2, Line 104: {"type":"function","function":{"name":"get_tables_queried","description":"Get list of tables queried.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (168 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@105 PS2, Line 105: {"type":"function","function":{"name":"get_resource_estimates","description":"Get memory/resource estimate sections.","parameters":{"type":"object","properties":{},"required":[]}}}, line too long (183 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@106 PS2, Line 106: {"type":"function","function":{"name":"get_analyzed_query","description":"Get the analyzed/optimized query text.","parameters":{"type":"object","properties":{},"required":[]}}} line too long (178 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@131 PS2, Line 131: Status BuildAgentPayloadJson(const vector<ChatMessage>& conversation, string* payload_json) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@260 PS2, Line 260: string(ANALYSIS_PROMPT) + "\n\nInitial profile context:\n" + initial_summary_json, "", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@272 PS2, Line 272: "payload", Value(payload_json.c_str(), impala_options_alloc), impala_options_alloc); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@381 PS2, Line 381: RETURN_IF_ERROR(profile_tool_executor(tool_name, tool_args_json, &tool_output_json)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24284/2/be/src/service/query-profile-ai-analysis.cc@392 PS2, Line 392: "result", Value(tool_result_doc, tool_doc.GetAllocator()), tool_doc.GetAllocator()); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 2 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2026 22:17:39 +0000 Gerrit-HasComments: Yes
