Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24284/3/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/3/be/src/service/query-profile-ai-analysis.cc@72 PS3, Line 72: esimates nit. estimates http://gerrit.cloudera.org:8080/#/c/24284/3/be/src/service/query-profile-ai-analysis.cc@510 PS3, Line 510: string tool_call_id; : if (tool_call.HasMember("id") && tool_call["id"].IsString()) { : tool_call_id = tool_call["id"].GetString(); : } : conversation.push_back({"tool", tool_json, tool_call_id, ""}); Are we trying to push an empty tool_call_id anyway here? Is it abnormal that the tool_call doesn't have an id? If yes, maybe it is better to LOG(WARNING) for the empty id case or skip this tool? -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 3 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 20:10:12 +0000 Gerrit-HasComments: Yes
