Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directive before dropping a table ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10792/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10792/1//COMMIT_MSG@9 PS1, Line 9: drop a table while the catalog is : loading it. If the HDFS files of a partition are removed when the : partition is being loaded, the catalog object will be in an inconsistent : state and the catalog will fail to recognize some cached partitions and : not remove the cache directives Can you clarify what this means? Looking at the code, getOrLoadTable() and removeTable() are synchronized on 'versionLock_'. (or) you mean they are removed external to Impala like using Hive / Hadoop? Just want to be sure that I understand the problem correctly. http://gerrit.cloudera.org:8080/#/c/10792/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10792/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1452 PS1, Line 1452: catch (NoSuchObjectException e) { : throw new ImpalaRuntimeException(String.format("Table %s no longer exists in " + : "the Hive MetaStore. Run 'invalidate metadata %s' to update the Impala " + : "catalog.", tableName, tableName)); : } catch (TException e) { : throw new ImpalaRuntimeException( : String.format(HMS_RPC_ERROR_FORMAT_STR, "dropTable"), e); : } You mean if we happen to throw any of these, we don't uncache the table? -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 21:05:57 +0000 Gerrit-HasComments: Yes
