Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directive before dropping a table ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10792/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10792/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1317 PS2, Line 1317: if (db != null) { I don't think this is the right approach. Firstly this is still prone to races. Secondly, if the dropDatabase() in L1324 fails for some reason, we'd have unnecessarily uncached the tables eagerly. How about fixing the HdfsPartition.dropPartition() to also cleanup the partition directive? (refer to my example in the CR comment). -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Tue, 03 Jul 2018 07:47:12 +0000 Gerrit-HasComments: Yes
