Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 3: (2 comments) Addressed code review from Jason Fehr http://gerrit.cloudera.org:8080/#/c/24282/2/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/2/be/src/service/query-profile-redaction.cc@79 PS2, Line 79: static unordered_map<string, string> BuildAliasReverseMap( > Will double quotes within the string also mess up JSON serialization? No, rapidjson::Writer::String(...) escapes embedded quotes inside the payload as \". erase_first/erase_last here only strip the outer JSON quotes, not the escaped internal ones. http://gerrit.cloudera.org:8080/#/c/24282/2/be/src/service/query-profile-redaction.cc@104 PS2, Line 104: // Adds hostname-like regex matches to the provided deduplicated token set. > Why return a vector instead of just returning the unique set? We use a vector here in order to maintain consistent ordering for matches found, so that when aliases are applied they can be assigned deterministically (helps especially with avoiding flaky golden file comparison for unit tests). -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 3 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 01:50:17 +0000 Gerrit-HasComments: Yes
