Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction.cc@103 PS4, Line 103: for (std::sregex_iterator it(section.cbegin(), section.cend(), HOST_WITH_PORT_RE), end; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction.cc@356 PS4, Line 356: redacted = BuildApplyAndTrackAliases(username_tokens, "user", redacted, alias_to_original); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction.cc@366 PS4, Line 366: redacted = BuildApplyAndTrackAliases(table_tokens, "table", redacted, alias_to_original); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction.cc@367 PS4, Line 367: redacted = BuildApplyAndTrackAliases(column_tokens, "column", redacted, alias_to_original); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 4 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 21:51:48 +0000 Gerrit-HasComments: Yes
