Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24294 )
Change subject: IMPALA-14970: Time-travel queries can throw UnsupportedOperationException ...................................................................... Patch Set 1: (2 comments) Thank you for the fix. I have some questions regarding the scope and effect of this list. http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG@13 PS1, Line 13: Collections.synchronizedList() Why is it synchronized? Is it used per table or per query? http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG@20 PS1, Line 20: * unit tests added for ListMap : * e2e tests added for Iceberg tables + time-travel Our tests run in local catalog mode by default. Is there any expectation of a different behavior in legacy catalog mode that makes sense to test it as well? -- To view, visit http://gerrit.cloudera.org:8080/24294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3773eb7a37e9918501bfa8a22707967e79024aca Gerrit-Change-Number: 24294 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 09:30:09 +0000 Gerrit-HasComments: Yes
