Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24294 )
Change subject: IMPALA-14970: Time-travel queries can throw UnsupportedOperationException ...................................................................... Patch Set 1: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG@13 PS1, Line 13: Collections.synchronizedList() > Why is it synchronized? Is it used per table or per query? Depends on catalog mode: * Legacy Catalog: it belongs to the table and re-used across queries. Parallel time-travel queries could add entries concurrently. It worked before this patch, because in HdfsTable.loadFromThrift() we passed a modifiable list to populate(). * Local Catalog: We have a LocalIcebergTable per query, and each object has its own host index. I.e. synchronization is not required in this case, but doesn't hurt either. http://gerrit.cloudera.org:8080/#/c/24294/1//COMMIT_MSG@20 PS1, Line 20: * unit tests added for ListMap : * e2e tests added for Iceberg tables + time-travel > Our tests run in local catalog mode by default. Is there any expectation of IcebergTable/HdfsTable work differently as they cached across queries. Legacy catalog mode is seriously under-tested right now. Instead of writing a custom-cluster test for each test file, we should probably have a job that exercises all the e2e tests with legacy catalog mode. Or, we should just deprecate legacy catalog mode for good. I think it should be handled outside of this ticket, filed IMPALA-14984. http://gerrit.cloudera.org:8080/#/c/24294/1/fe/src/test/java/org/apache/impala/util/ListMapTest.java File fe/src/test/java/org/apache/impala/util/ListMapTest.java: http://gerrit.cloudera.org:8080/#/c/24294/1/fe/src/test/java/org/apache/impala/util/ListMapTest.java@66 PS1, Line 66: followings > nit: following Done -- To view, visit http://gerrit.cloudera.org:8080/24294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3773eb7a37e9918501bfa8a22707967e79024aca Gerrit-Change-Number: 24294 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 12:54:30 +0000 Gerrit-HasComments: Yes
