Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 )
Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG@12 PS1, Line 12: the logs : will contain a new line for every occurrence seems like we could change that generally. http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG@22 PS1, Line 22: fragments RuntimeState is per fragment instance state. It's not shared between fragments or even instances. In that regard, it's already the per-thread state for most of execution. The scanners are currently (with mt_dop=0) the important exception. So then, what is the primary reason to add the new class? Is it to avoid the locking or avoid the log spew. For the former, perhaps this new class would be better to live somewhere specific to the scanners (otherwise, I think it's unclear whether code should use this class or call directly to the LogError() interface). For the latter, we can additionally consider fixing LogError() to avoid the redundant logs (note that most callers of LogError() are the scanners especially in cases that will produce many messages). -- To view, visit http://gerrit.cloudera.org:8080/10793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b7c1fd020a7ba5e0d9c619e1b67236dce198aa Gerrit-Change-Number: 10793 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 22:16:37 +0000 Gerrit-HasComments: Yes
