Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 )
Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG@12 PS1, Line 12: the logs : will contain a new line for every occurrence > seems like we could change that generally. I was hesitant to go that way, because messages with the same error code but different parameters can contain useful information (for example different column names). http://gerrit.cloudera.org:8080/#/c/10793/1//COMMIT_MSG@22 PS1, Line 22: fragments > Right, but I don't think we do much LogError() from that (other than from i I agree that this logic would be mainly useful for scanners. KuduSink has a per row error though (TErrorCode::KUDU_NULL_CONSTRAINT_VIOLATION). I thought about adding these functions to scanner code, but I did not find a suitable class - HdfsScanner would be a good candidate, but it does not have common ancestors with KuduScanner, and both classes should be able to use this logic. Do you have a good place in mind? The primary motivation is to avoid massive logging with this specific message. Avoiding locking came up as a secondary benefit, as it seemed trivial to implement it with the new interface. -- To view, visit http://gerrit.cloudera.org:8080/10793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b7c1fd020a7ba5e0d9c619e1b67236dce198aa Gerrit-Change-Number: 10793 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 14:45:30 +0000 Gerrit-HasComments: Yes
