Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements ...................................................................... Patch Set 2: Code-Review+2 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/24303/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24303/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@301 PS2, Line 301: Precondition: targetPartitionExpressions_ is non-empty. Why not using Preconditions.checkState()? -- To view, visit http://gerrit.cloudera.org:8080/24303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739 Gerrit-Change-Number: 24303 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 13:56:38 +0000 Gerrit-HasComments: Yes
