Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements ...................................................................... IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements isPartitioned() checks all historical partition specs, not just the current default spec. A table that was created with a non-VOID partition spec and then evolved to all-VOID still returns true from isPartitioned(). The fix guards the partitioned V3 shuffle path with an additional !targetPartitionExpressions_.isEmpty() check so that a table whose current spec has no active partition fields uses PARTITION__SPEC__ID and ICEBERG__PARTITION__SERIALIZED for shuffling. Testing: - Added a new test case to iceberg-v3-merge.test. Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739 Reviewed-on: http://gerrit.cloudera.org:8080/24303 Reviewed-by: Zoltan Borok-Nagy <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739 Gerrit-Change-Number: 24303 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
