Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@142 PS7, Line 142: static vector<pair<string_view, string_view>> GetSortedReplacementEntries( Add comment explaining what this function does. http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@149 PS7, Line 149: sort(entries.begin(), entries.end(), Add a comment explaining why we need to sort the entries. http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@157 PS7, Line 157: static bool ReplacementTokenCollides(const string& token, const string& text, Add comments explaining what this function does. http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@167 PS7, Line 167: static Status BuildReplacementToken(size_t idx, const string& text, Add comments explaining what this function does. http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@191 PS7, Line 191: vector<pair<string, string>> pending_restores; We could use vector<pair<string, string_view>> pending_restores as the 'to' entry points to string in entries. http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@201 PS7, Line 201: boost::algorithm::replace_all(text, string(from), token); We can pass 'from' as is (string_view) http://gerrit.cloudera.org:8080/#/c/24282/7/be/src/service/query-profile-redaction.cc@202 PS7, Line 202: pending_restores.emplace_back(move(token), string(to)); We can pass 'to' as is (string_view) -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 7 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 15 May 2026 04:12:10 +0000 Gerrit-HasComments: Yes
