Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24282/4/be/src/service/query-profile-redaction-test.cc@79 PS4, Line 79: TEST(QueryProfileRedactionTest, RedactedProfileMatchesGoldenForTpcds72) { > Added a unit test for this edge case Thanks. I think we can also add some negative test cases to verify it is not crashing: 1. Empty string input and some random malformed JSON as the input profile_text. 2. Normal profile_text input, but unredact with some unrelated random text. Besides, could we also have a test to cover all the regex patterns (EMAIL_RE, IP_RE, SNAKE_CASE_ID_RE, HOST_WITH_PORT_RE, etc.)? It would be great to have a simple, isolated test case with a dummy JSON string to ensure the regexes catch them all correctly and don't regress in the future http://gerrit.cloudera.org:8080/#/c/24282/6/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/6/be/src/service/query-profile-redaction.cc@197 PS6, Line 197: // Builds aliases from tokens, applies them to text, and tracks reverse mappings. nit. The comment is better to sit above the code, we can move it above the template -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 6 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 21:32:45 +0000 Gerrit-HasComments: Yes
