Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@51 PS15, Line 51: : static constexpr const char* REDACTED_SQL_STATEMENT = "[REDACTED_SQL_STA > These should probably be startup options so that these could be tuned if ne Done http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@90 PS15, Line 90: regex::optimize | regex::nosubs); > We should get process mem_limit from: Done http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@388 PS15, Line 388: const unordered_set<string_view>& target_keys, vector<string>* values) { > seen_host_tokens could be removed as profile should only have unique hosts Done http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@473 PS15, Line 473: } > We should avoid this copy as profiles could be quite huge. We should update Done -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 16 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 19:24:36 +0000 Gerrit-HasComments: Yes
