Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@51 PS15, Line 51: static constexpr int64_t MAX_REDACTION_PROFILE_SIZE_LIMIT_BYTES = 256L * 1024L * 1024L; : static constexpr int64_t PROFILE_SIZE_LIMIT_MEM_FRACTION_DIVISOR = 100L; These should probably be startup options so that these could be tuned if needed. For reference: https://github.com/apache/impala/blob/master/be/src/service/data-stream-service.cc#L50 http://gerrit.cloudera.org:8080/#/c/24282/15/be/src/service/query-profile-redaction.cc@90 PS15, Line 90: const int64_t host_mem_limit = MemInfo::physical_mem(); We should get process mem_limit from: ``` ExecEnv::GetInstance()->process_mem_tracker()->limit() ``` -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 15 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 05:37:02 +0000 Gerrit-HasComments: Yes
