Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24316 )

Change subject: IMPALA-15001: OpenTelemetry Query Tracing not working with 
fallback planner
......................................................................


Patch Set 3:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24316/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/24316/3/fe/src/main/java/org/apache/impala/service/Frontend.java@343
PS3, Line 343:     // null (decision not yet made, e.g. before parsing or after 
a failed planner attempt),
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24316/3/fe/src/main/java/org/apache/impala/service/Frontend.java@3334
PS3, Line 3334:       planCtx.queryTraced_ = parsedStmt != null && 
BackendConfig.INSTANCE.isOtelTraceEnabled()
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id44125bce8d6ec3d1294b1055b7cb3a49b5f06c9
Gerrit-Change-Number: 24316
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Sat, 16 May 2026 21:21:33 +0000
Gerrit-HasComments: Yes

Reply via email to