Hello Quanlong Huang, Jason Fehr, Surya Hebbar, Michael Smith, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24316
to look at the new patch set (#4).
Change subject: IMPALA-15001: OpenTelemetry Query Tracing not working with
fallback planner
......................................................................
IMPALA-15001: OpenTelemetry Query Tracing not working with fallback planner
Some tests within test_otel_trace.py are failing when the USE_CALCITE_PLANNER
environment variable is set to true (i.e. test_select_values)
If the parsing fails for the Calcite planner, the trace is set to false. It
then falls back to the original planner which does not attempt to set
the trace value to true, so the tracing information does not get sent.
This fix reset the tracing variable on each retry.
One issue with this fix is that it will lose any tracing information for
failures before fallback, but this should be ok. If tracing information
is needed for Calcite only, the workaround would be to run with no fallback
planner.
Note to reviewers: Does the above seem reasonable? Will delete this comment
before committing.
Testing: Ran test_otel_trace.py both with and without USE_CALCITE_PLANNER=true
Change-Id: Id44125bce8d6ec3d1294b1055b7cb3a49b5f06c9
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 53 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/24316/4
--
To view, visit http://gerrit.cloudera.org:8080/24316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id44125bce8d6ec3d1294b1055b7cb3a49b5f06c9
Gerrit-Change-Number: 24316
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
